Re: [Xen-devel] [PATCH RFC 5/5] libxl/FreeBSD: add support for disk hotplug scripts

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

El 17/06/15 a les 15.23, Ian Campbell ha escrit:
> On Fri, 2015-05-22 at 11:18 +0200, Roger Pau Monne wrote:
>> Allow FreeBSD to execute hotplug scripts when attaching disk devices.
>>
>> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> 
> This looks rather similar to the code for Linux, is there any chance
> they could be combined into one or more common hotplugger running
> things?

Although much of the code is similar, the syntax of the disk hotplug
script call is different on Linux vs FreeBSD. Linux calls the hotplug
script with a single parameter (add or remove) and passes a bunch of
data in the env. FreeBSD OTOH passes the backend xenstore path as the
first argument and doesn't set any env variables at all.

Both paths could be merged, but I think the resulting code is going to
be a little messy, and unless people is really careful Linux changes
could break FreeBSD or the other way around, and there's a great chance
people are not going to test on both Linux and FreeBSD.

So, IMHO I would prefer to keep them separated for now.

Roger.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel