[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format



Hi Ian,

On 17/06/2015 10:25, Ian Campbell wrote:
On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.

Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx

You meant s/Append/Prepend/, nonetheless:

I noticed a missing word after "avoid" in the commit message too. I will update to:

"Prepend 0x to all %x in order to avoid confusion while reading when there is other decimal value in the log.

[...]".


Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I see different opinion on whether using 0x% or %#. As I plan to resend a version with the commit message update, shall I use %#?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.