[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format
On Tue, 2015-06-16 at 23:07 +0300, Sergei Shtylyov wrote: > On 06/16/2015 10:10 PM, Julien Grall wrote: > > Append 0x to all %x in order to avoid while reading when there is other > > decimal value in the log. [] > > @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct > > xenvif_queue *queue, > > if (unlikely(queue->grant_tx_handle[pending_idx] != > > NETBACK_INVALID_HANDLE)) { > > netdev_err(queue->vif->dev, > > - "Trying to overwrite active handle! pending_idx: > > %x\n", > > + "Trying to overwrite active handle! pending_idx: > > 0x%x\n", > > Using "%#x" is shorter ind does the same. That's true, but it's also far less common. $ git grep -E "%#[\*\d\.]*x" | wc -l 1419 $ git grep "0x%" | wc -l 29844 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |