Re: [Xen-devel] [PATCH 01/27] tools/libxl: Fix libxl__ev_child_inuse() check for not-yet-initialised children

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 01/27] tools/libxl: Fix 
libxl__ev_child_inuse() check for not-yet-initialised children"):
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> > Shortly, libxl will be juggling multiple parallel operations, and will
> > possibly have to take error decisions before some tasks have been set up.
> 
> It would be preferable, I think, to arrange to call libxl__ev_child_init
> on all such libxl__ev_child structs either up front or certainly before
> there is any possibility of needing to unwind them.

Yes.

> Such an init would at worst correspond to exactly the place where the
> zeroed structure you refer to is zeroed.

I would welcome a patch which caused an assertion failure if ->pid==0.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel