Re: [Xen-devel] [PATCH v2 6/6] libxl/save: Refactor libxl__domain_suspend_state

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote:
> Currently struct libxl__domain_suspend_state contains 2 type of states,
> one is save state, another is suspend state. This patch separate it out.

"This patch separates those two out".

> The motivation of this is that COLO will need to do suspend/resume
> continuesly, we need a more common suspend state.

"continuously"

> After this change, dss stands for libxl__domain_save_state,
> dsps stands for libxl__domain_suspend_state.
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I presume this is almost entirely mechanical and the compiler mostly
took care of identifying everywhere to be changed:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

[...]
> @@ -2839,9 +2840,27 @@ typedef struct libxl__logdirty_switch {
>  } libxl__logdirty_switch;
>  
>  struct libxl__domain_suspend_state {
[...]
> +struct libxl__domain_save_state {

Please could you add a little comment before each of these explaining
their scope for the hard of thinking (i.e. me). One is the live phase
and one is the final stop-and-copy phase, I think.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel