Re: [Xen-devel] [PATCH v9 05/13] x86: expose CBM length and COS number information

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.06.15 at 06:53, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> General CAT information such as maximum COS and CBM length are exposed to
> user space by a SYSCTL hypercall, to help user space to construct the CBM.
> 
> Signed-off-by: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Changes in v9:
> * Initialize 'info' explictly so that compiler would not complain.

This wouldn't be needed if ...

> --- a/xen/arch/x86/psr.c
> +++ b/xen/arch/x86/psr.c
> @@ -216,6 +216,38 @@ void psr_ctxt_switch_to(struct domain *d)
>      }
>  }
>  
> +static int get_cat_socket_info(unsigned int socket,
> +                               struct psr_cat_socket_info **info)
> +{
> +    if ( !cat_socket_info )
> +        return -ENODEV;
> +
> +    if ( socket >= nr_sockets )
> +        return -EBADSLT;
> +
> +    if ( !test_bit(socket, cat_socket_enable) )
> +        return -ENOENT;
> +
> +    *info = cat_socket_info + socket;
> +
> +    return 0;
> +}

... you made this return struct psr_cat_socket_info *, using what
xen/err.h provides.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel