Re: [Xen-devel] [v3][PATCH 10/16] tools: extend xc_assign_device() to support rdm reservation policy

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2015/6/15 22:58, Wei Liu wrote:
> On Mon, Jun 15, 2015 at 09:12:17AM +0800, Chen, Tiejun wrote:
> > On 2015/6/12 23:43, Wei Liu wrote:
> > > On Thu, Jun 11, 2015 at 09:15:19AM +0800, Tiejun Chen wrote:
> > > [...]
> > > > -static int next_bdf(char **str, int *seg, int *bus, int *dev, int *func)
> > > > +static int next_bdf(char **str, int *seg, int *bus, int *dev, int *func,
> > > > +                    int *flag)
> > > This is unrelated change. It should be moved to appropriate patch.
> > This is in the tools/python/xen/lowlevel/xc/xc.c file,
> >
> > pyxc_assign_device
> >      |
> >      + while ( next_bdf(&pci_str, &seg, &bus, &dev, &func, &flag) )
> >         |
> >         + ...
> >         |
> >         + xc_assign_device()
> >
> > this really should be related to extend xc_assign_device().
> Right, this is fine then.
>
> Please write in the commit message that you also adjusted all language
> bindings. Normally when I notice the code doesn't match the commit
I want to add this line into the patch head description,

"Note this also bring some fallout to python usage of xc_assign_device()."

> message I become very skeptical about the code.
Sorry for this confusion.

Thanks
Tiejun


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel