[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/4] Allow vif= to specify PCI address for each nic
On Mon, Jun 15, 2015 at 10:15:51AM -0400, Don Slutz wrote: > This allows more then 32 nics. > How does this patch help? What prevents you from having more than 32 nics? > This can help with Windows finding nics at boot time. > > This allows changing config file: > > builder = "hvm" > device_model_args_hvm = [ > "-device", > > "pci-bridge,chassis_nr=2,msi=on,id=pciBridge5.0,multifunction=on,addr=0x15.0", > "-device", > > "vmxnet3,id=nic3,netdev=net3,mac=00:0c:29:86:44:be,bus=pciBridge5.0,addr=0x4.0x0", > "-netdev", > "type=tap,id=net3,ifname=vif.3-emu,script=/etc/qemu-ifup,downscript=no", > ] > vif = [ > ] > > to: > > builder = "hvm" > device_model_args_hvm = [ > "-device", > > "pci-bridge,chassis_nr=2,msi=on,id=pciBridge5.0,multifunction=on,addr=0x15.0", > ] > vif = [ > > "model=vmxnet3,bridge=xenbr0,mac=00:0c:29:86:44:a0,bus=pciBridge5.0,addr=0x4.0x0", > ] > > which enables usage of xen-netback. > In any case, exposing HVM-only options to top-level vif configuration space doesn't look right. Why do you want to set bus and addr? The rationale should be stated in commit message. > Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx> > CC: Don Slutz <dslutz@xxxxxxxxxxx> > --- > docs/misc/xl-network-configuration.markdown | 14 ++++++++++++++ > tools/libxl/libxl_dm.c | 23 ++++++++++++++++++++--- > tools/libxl/libxl_types.idl | 2 ++ > tools/libxl/xl_cmdimpl.c | 4 ++++ > 4 files changed, 40 insertions(+), 3 deletions(-) > > diff --git a/docs/misc/xl-network-configuration.markdown > b/docs/misc/xl-network-configuration.markdown > index 3c439d4..6a7f6db 100644 > --- a/docs/misc/xl-network-configuration.markdown > +++ b/docs/misc/xl-network-configuration.markdown > @@ -60,6 +60,20 @@ strategy. Otherwise in general you should prefer to > generate a random > MAC and set the locally administered bit since this allows for more > bits of randomness than using the Xen OUI. > > +### bus > + > +Specifies the name of the network bridge which this VIF should be > +added to. The default is `xenbr0`. The bridge must be configured using > +your distribution's network configuration tools. See the [wiki][net] > +for guidance and examples. > + > +### addr > + > +Specifies the name of the network bridge which this VIF should be > +added to. The default is `xenbr0`. The bridge must be configured using > +your distribution's network configuration tools. See the [wiki][net] > +for guidance and examples. > + The above two paragraphs don't make sense to me. Is that copy-n-paste error? Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |