Re: [Xen-devel] [PATCH v6 COLO 02/15] secondary vm suspend/resume/checkpoint code

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [Xen-devel] [PATCH v6 COLO 02/15] secondary vm 
suspend/resume/checkpoint code"):
> On Mon, Jun 08, 2015 at 11:45:46AM +0800, Yang Hongyang wrote:
> > From: Wen Congyang <wency@xxxxxxxxxxxxxx>
> > +    crcs->status = LIBXL_COLO_RESUMED;
> > +
> > +    /* avoid calling libxl__xc_domain_restore_done() more than once */
> > +    if (crs->saved_cb) {
> > +        dcs->callback = crs->saved_cb;
> > +        crs->saved_cb = NULL;
> 
> I have a feeling that this trick should be avoided. But I'm not an
> expert on this so I will defer judgement to Ian J.

Yes, this trick should be avoided.  It will make the resulting
control flow very confusing.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel