[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 COLOPre 13/13] tools/libxl: don't touch remus in checkpoint_device
On Mon, Jun 08, 2015 at 11:43:17AM +0800, Yang Hongyang wrote: > Checkpoint device is an abstract layer to do checkpoint. > COLO can also use it to do checkpoint. But there are > still some codes in checkpoint device which touch remus: > 1. remus_ops: we use remus ops directly in checkpoint > device. Store it in checkpoint device state. > 2. concrete layer's private member: add a new structure > remus state, and move them to remus state. > 3. init/cleanup device subkind: we call (init|cleanup)_subkind_nic > and (init|cleanup)_subkind_drbd_disk directly in checkpoint > device. Call them before calling libxl__checkpoint_devices_setup() > or after calling libxl__checkpoint_devices_teardown(). > From the look of it this patch is mostly refactoring and doesn't involve functional changes, right? If so please state that in commit message. I suppose this needs review from remus maintainer. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |