Re: [Xen-devel] [PATCH OSSTEST] Arrange to upgrade microcode on x86 test hosts.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST] Arrange to upgrade microcode on x86 
test hosts."):
> On Thu, 2015-06-11 at 16:39 +0100, Ian Jackson wrote:
> > If $c{prop} is undef, the logm will produce a warning.  Maybe you want
> > //'' somewhere.
> 
> I think that was a stray wip debug thing, I could fix, remove or move it
> below the check of $c{$prop}. 

Any of those would be fine by me.

> > This use of caps lock for unexported shell variables is rather
> > unidiomatic, don't you think ?
> 
> I'm not really in the habit of caring for short scripts, but I'll down
> case them.

I find it confusing, because I want to know what other process is
going to be using them.  Thanks.

> > mg-debian-installer-update is idempotent.  Perhaps this script should
> > be too ?  After all you can only overwrite something generated today.
> 
> True. I'll arrange that.
> 
> I'll see if I can also make it deterministic like with the installer
> stuff, which will make spotting differences easier.

Great.

> > > +for BIN in $AMD_BINS ; do
> > > +    curl -s $LINUX_FW/plain/$BIN > $BIN
> > > +done
> > 
> > We're really fetching these via the gitweb/cgit/... ?  Isn't that a
> > bit fragile ?
> 
> A bit, yes. The alternative is to clone the whole of linux-firmware.git.
> I suppose with --depth=1 that might not be so bad. Would you prefer
> that?

Yes.

Will go on to read your v2 just now...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel