Re: [Xen-devel] [PATCH V3 3/6] libxl: add pvusb API

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH V3 3/6] libxl: add pvusb API"):
> On Mon, May 18, 2015 at 09:20:43PM -0600, Chun Yan Liu wrote:
> > Thanks, I'm updating that. But maybe like pci_add and pci_remove functions,
> > will add a 'starting' flag to indicate hotplug or creation.
> > Looking at DEFINE_DEVICE_ADD and DEFINE_DEVICE_REMOVE, usbctrl_add
> > and usb_add can use DEFINE_DEVICE_ADD; but usbctrl_remove and usb_remove
> > cannot use DEFINE_DEVICE_REMOVE directly, need some extra handling. So,
> > finally turned to not use these macros but refer to pci functions.
> 
> TBH I prefer to have only one way to deal with devices.  I personally
> prefer the async style that every other devices use. Maybe that's just
> because I mostly worked with those.
> 
> I don't know the full history of libxl_pci.c so I will wait for Ian and
> Ian's comments on which way to go.

libxl_pci.c is rather unfortunate in a few respects.  It does a number
of things things synchronously that it shouldn't.

Certainly the external API for all device add/remove functions should
be async.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel