Re: [Xen-devel] [PATCH V4 1/7] libxl: export some functions for pvusb use

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jun 11, 2015 at 05:08:57PM +0100, Ian Jackson wrote:
> Chunyan Liu writes ("[Xen-devel] [PATCH V4 1/7] libxl: export some functions 
> for pvusb use"):
> > Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>
> > Signed-off-by: Simon Cao <caobosimon@xxxxxxxxx>
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ...
> >  /* generic callback for devices that only need to set ao_complete */
> > -static void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device 
> > *aodev)
> > +void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev)
> 
> Functions in libxl with external linkage should have the appropriate
> namespacing (ie, their names must start with libxl__).
> 
> So, I'm afraid, contrary to Wei's opinion:
> 
> Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 

I think if Chunyan moves that function to libxl__ namespace this patch
should be fine, right?

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel