Re: [Xen-devel] [OSSTEST Nested PATCH v11 5/7] Add new script to customize nested test configuration

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Pang, LongtaoX writes ("RE: [OSSTEST Nested PATCH v11 5/7] Add new script to 
customize nested test configuration"):
> [Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]]
> > longtao.pang writes ("[OSSTEST Nested PATCH v11 5/7] Add new script to
> > > +target_cmd_root($l1, "update-rc.d osstest-confirm-booted start 99 2 .");
> > 
> > This is an open coded copy of the code from ts-host-install.  It
> > should be broken out, I think.
> > 
> I am sorry, could you please make it more clear? Thanks.

I mean that your patch introduces an additional copy of this line:

    target_cmd_root($l1, "update-rc.d osstest-confirm-booted start 99 2 .");

If we should ever change the way this works, we would then need to
change it in two places.

I think you should move this out into its own function, and call it
from both places.  I'm not sure exactly what it shoudl be called, but
maybe `host_install_postboot_complete' ?

> > > +target_install_packages_norec($l1, qw(lvm2 rsync genisoimage));
> > 
> > Do we need to install genisoimage here ?  The guest install scripts do
> > it.  Or are we just doing it here for efficiency reasons ?
> 
> In fact, there is no need to install ' genisoimage' here.  It's just
> for efficiency reason, since if install this package here, it will
> not be installed in 'ts-debian-hvm-install' script again.  So, do
> you prefer to discard it or keep it here? I think there is no
> harmful to install this package here.

It's not harmful, indeed.  I think it would be worth adding a comment
saying that these are installed here merely for efficiency reasons.

> > We would avoid having to mention /dev/xvdb if we created the VG in the
> > host, before doing block-attach.  I'm not sure whether that's an
> > improvement.
> 
> I am sorry, I cannot get your point. Could you please make it more
> clear? Thanks.

As you explain in the comment, you have to mention /dev/xvdb here even
though after rebooting into Xen this will be /dev/sdb.

This wrinkle would become invisible if you did pvcreate and vgcreate
in the L0 (before attach), rather than the L1 (after attach).
Because, then none of your operations on L1 would not need to name the
physical device.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel