Re: [Xen-devel] [OSSTEST Nested PATCH v11 7/7] Add test job for nest test case

["Pang, LongtaoX" <longtaox.pang@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> Sent: Wednesday, June 10, 2015 11:46 PM
> To: Pang, LongtaoX
> Cc: xen-devel@xxxxxxxxxxxxx; Ian.Campbell@xxxxxxxxxx; wei.liu2@xxxxxxxxxx; Hu,
> Robert
> Subject: Re: [OSSTEST Nested PATCH v11 7/7] Add test job for nest test case
> 
> longtao.pang writes ("[OSSTEST Nested PATCH v11 7/7] Add test job for nest 
> test
> case"):
> > 1. This patch adds creation of the nested test job, when job creation
> > procedure is invoked.
> > 2. Set nested L1's vif model, nestedhvm feature, set specific disk
> > size and memory size for nested test by make-flight.
> ...
> 
> This is nearly right, I think.
> 
> > +  job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-nested \
> > +            test-nested xl $xenarch $dom0arch $qemuu_runvar \
> > +            nestedl1_image=debian-7.2.0-amd64-CD-1.iso \
> > +            nestedl1_vifmodel='e1000' \
> > +            nestedl1_disksize='15000' \
> > +            nestedl1_memsize='3072' \
> > +            nestedl1_enable_nestedhvm='true' \
> > +            nestedl1_guest_storage_size='20000' \
> > +            nestedl2_image=debian-7.2.0-amd64-CD-1.iso \
> > +            nestedl2_disksize='15000' \
> > +            bios=$bios
> > +            all_hostflags=$most_hostflags,hvm
> 
> Some observations:
>  * The \ should be aligned to a column at the RHS.  If you did that
>    you would have noticed that:
>  * You are missing a \
>  * Most of the '' are unnecessary.
Thanks for pointing out these.
>  * Why do you specify the l2 disk size explicitly ?
Just for some configure rule in our lab, we assign at least '15000M' disk size 
for nested L2 guest, 
since it's no harmful, I think.
Actually, it works fine if not specify the l2 disk size and using default 
'10000M'.
So, you prefer to use default disk size for l2 guest, right?
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel