[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: gic-hip04: Resync the driver with the GICv2



On 09/06/2015 09:03, Shameerali Kolothum Thodi wrote:
Hi Julien/Zoli,

Hi Shameer,

http://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-huawei/gicv2-on-gicv3
I had a run of this staging on our D01 board.

Thank you for testing.

Xen fails to boot with below error:
(XEN) domain 0: vGIC requested is not supported
(XEN) CPU0: Unexpected Trap: Data Abort

After going through the code, it looks to me that hip04 gicv2_info is missing 
the vgic_versions initialisation. Made the following changes and xen booted and 
started dom0.

--- ../xen-org/arch/arm/gic-hip04.c   2015-06-01 16:33:40.000000000 +0100
+++ ./xen/arch/arm/gic-hip04.c  2015-06-09 13:21:44.355012016 +0100
@@ -735,6 +735,7 @@ static int __init hip04gic_preinit(struc
                                     const void *data)
  {
      gicv2_info.hw_version = GIC_V2;
+    gicv2_info.vgic_versions = GIC_V2;
      gicv2_info.node = node;
      register_gic_ops(&hip04gic_ops);
      dt_irq_xlate = gic_irq_xlate;

(Sorry, this is a diff not a proper git patch)
Please correct me, if this is not the correct way to init the vgic_versions.

This is correct. Although, I'm planning to rework the way that the GIC tells the supported vGIC in the next version of this GICv2 on GICv3 series.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.