Re: [Xen-devel] [PATCH 2/4] EFI/early: add /mapbs to map EfiBootServices{Code, Data}

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/06/15 15:11, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 09, 2015 at 03:03:18PM +0100, Andrew Cooper wrote:
>> On 09/06/15 14:53, Jan Beulich wrote:
>>> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>>
>>> To help on certain platforms to run.
>>>
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>
>>> --- a/xen/arch/x86/efi/efi-boot.h
>>> +++ b/xen/arch/x86/efi/efi-boot.h
>>> @@ -148,12 +148,16 @@ static void __init efi_arch_process_memo
>>>  
>>>          switch ( desc->Type )
>>>          {
>>> -        default:
>>> -            type = E820_RESERVED;
>>> -            break;
>>> -        case EfiConventionalMemory:
>>>          case EfiBootServicesCode:
>>>          case EfiBootServicesData:
>>> +            if ( map_bs )
>> if ( !map_bs ) surely?  It is the else case which sets a type of E820_RAM.
> We want the EfiBootServices{Code|Data} to be E820_RESERVED and this
> sets it to that if map_bs is set.
>
> If map_bs is not set then we treat it as E820_RAM.

Ah of course - sorry for the confusion.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel