Re: [Xen-devel] [RFC v2 06/15] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.15 at 11:07, <feng.wu@xxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.h
> +++ b/xen/drivers/passthrough/vtd/iommu.h
> @@ -289,7 +289,7 @@ struct dma_pte {
>  /* interrupt remap entry */
>  struct iremap_entry {
>    union {
> -    u64 lo_val;
> +    struct { u64 lo, hi; };
>      struct {
>          u64 p       : 1,
>              fpd     : 1,
> @@ -302,16 +302,28 @@ struct iremap_entry {
>              vector  : 8,
>              res_2   : 8,
>              dst     : 32;
> -    }lo;
> -  };
> -  union {
> -    u64 hi_val;
> +        u64 sid     : 16,
> +            sq      : 2,
> +            svt     : 2,
> +            res_3   : 44;
> +    }remap;
>      struct {
> +        u64 p       : 1,
> +            fpd     : 1,
> +            res_1   : 6,
> +            avail   : 4,
> +            res_2   : 2,
> +            urg     : 1,
> +            im      : 1,
> +            vector  : 8,
> +            res_3   : 14,
> +            pda_l   : 26;
>          u64 sid     : 16,
>              sq      : 2,
>              svt     : 2,
> -            res_1   : 44;
> -    }hi;
> +            res_4   : 12,
> +            pda_h   : 32;
> +    }post;
>    };
>  };

Same here - unless the VT-d maintainers disagree, I think using u32
wherever possible would be preferable over using u64, as well as
avoiding bitfields for members filling an entire word.

Also please fix the formatting (blanks between closing braces and field
names).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel