Re: [Xen-devel] [RFC v2 04/15] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.15 at 11:07, <feng.wu@xxxxxxxxx> wrote:
> Extend struct pi_desc according to VT-d Posted-Interrupts Spec.
> 
> Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> ---
>  xen/include/asm-x86/hvm/vmx/vmcs.h | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/include/asm-x86/hvm/vmx/vmcs.h 
> b/xen/include/asm-x86/hvm/vmx/vmcs.h
> index 6fce6aa..3707d1c 100644
> --- a/xen/include/asm-x86/hvm/vmx/vmcs.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h
> @@ -76,8 +76,19 @@ struct vmx_domain {
>  
>  struct pi_desc {
>      DECLARE_BITMAP(pir, NR_VECTORS);
> -    u32 control;
> -    u32 rsvd[7];
> +    union {
> +        struct
> +        {
> +        u64 on     : 1,  /* bit 256 - Outstanding Notification */

Unless really needed, please avoid u64 here; u32 or even unsigned
int would seem to do just fine, ...

> +            sn     : 1,  /* bit 257 - Suppress Notification */
> +            rsvd_1 : 14, /* bit 271:258 - Reserved */
> +            nv     : 8,  /* bit 279:272 - Notification Vector */
> +            rsvd_2 : 8,  /* bit 287:280 - Reserved */
> +            ndst   : 32; /* bit 319:288 - Notification Destination */

... allowing this to not be a bitfield member at all.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel