[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4] efi: Avoid calling boot services after ExitBootServices()
On Tue, 2015-06-09 at 14:26 +0100, Andrew Cooper wrote: > On 09/06/15 14:24, Ian Campbell wrote: > > On Tue, 2015-06-09 at 14:05 +0100, Ross Lagerwall wrote: > >> On 06/09/2015 01:53 PM, Ian Campbell wrote: > >>> In terms of the rest of the patch, are those two places changed to use > >>> SystemTable->BootServices instead of efi_bs, if the point of the patch > >>> is to not use BootServices after exit is called? > >>> > >> GetMemoryMap() and ExitBootServices() are the only functions explicitly > >> allowed after the first call to ExitBootServices() so they are called > >> via SystemTable->BootServices. efi_bs is set to NULL to ensure that no > >> other bootservices are called. > > I see. That might be worth a mention in the commit log? > > The commit message does say this. Is there anything you think needs > further clarification? It says just: After the first call to ExitBootServices(), avoid calling any boot services by setting setting efi_bs to NULL and halting in blexit(). No mention of the fact that GetMemoryMap() and ExitBootServices() are not covered by the blanket statement regarding boot services. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |