Re: [Xen-devel] [PATCH OSSTEST v2] Stubdom test case

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-06-08 at 20:54 +0100, Wei Liu wrote:
> Currently only QEMU traditional supports stubdom, so we only create
> 
> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64
> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm
> 
> Note that stubdom only supports serial='pty'. Piping serial to stderr
> causes stubdom to exit abnormally.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Changes in v2:
> 1. Don't set stubdom runvar for every test case.

From the list of runvars I don't think this happened correctly:

> +xen-unstable               test-amd64-amd64-xl-qemut-debianhvm-amd64         
>     enable_stubdom              false
> +xen-unstable               test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm     
>     enable_stubdom              false

etc etc

Also:

> +xen-unstable               test-amd64-amd64-xl-qemuu-debianhvm-amd64         
>     enable_stubdom
> +xen-unstable               test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm     
>     enable_stubdom
> +xen-unstable               test-amd64-amd64-xl-qemuu-ovmf-amd64              
>     enable_stubdom

I don't think is desired.

> +  stubdom_suffix="";
> +  if [ x$stubdom = xtrue ]; then
> +      stubdom_suffix="-stubdom"
> +  fi
> +
> +  job_create_test 
> test-$xenarch$kern-$dom0arch-xl$qemuu_suffix$stubdom_suffix-$testname-amd64\
>      test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
>      enable_xsm=$xsm                             \
> +    enable_stubdom=$stubdom                     \

if [ x$stubdom != x ] ; then
        stubdom_runvar="enable_stubdom=$stubdom"
fi

Then just pass $stubdom_runvar to job_create_test, this arranges that
enable_stubdom is only set if a specific value is requested.

> +      for stubdom in true false ; do

for stubdom in true '' ; do

then arranges to pass the right things into the above. May need more or
less quoting when $stubdom is used now.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel