Re: [Xen-devel] [PATCH RFC 0/4] 'reset everything' approach to PVHVM guest kexec

[Dave Scott <Dave.Scott@xxxxxxxxxx>]

> On 9 Jun 2015, at 10:38, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> On Tue, Jun 09, 2015 at 10:29:56AM +0100, Wei Liu wrote:
> [...]
>>>> +  con.next_tid <- initial_next_tid
>>> 
>>> I couldnât spot the part in the C version where the next transaction id is 
>>> reset â is this a (minor) difference between the two implementations, or 
>>> have I misread the code?
>>> 
>>> If you could clarify that for me, and assuming this all compiled ok, then 
>>> feel free to add
>>> 
>> 
>> Yes, it compiles OK.
>> 
>> I think I will just delete that line. I couldn't recollect why I added
>> that. Maybe it's copy-n-paste error.
>> 
>> Can I still have your ack if I drop that line?

Yes

>> 
> 
> And a new hunk will be added in the next version to deal with
> logging.ml.
> 
> diff --git a/tools/ocaml/xenstored/logging.ml 
> b/tools/ocaml/xenstored/logging.ml
> index 665b922..4c90032 100644
> --- a/tools/ocaml/xenstored/logging.ml
> +++ b/tools/ocaml/xenstored/logging.ml
> @@ -242,6 +242,7 @@ let string_of_access_type = function
>        | Xenbus.Xb.Op.Rm                -> "rm       "
>        | Xenbus.Xb.Op.Setperms          -> "setperms "
>        | Xenbus.Xb.Op.Restrict          -> "restrict "
> +       | Xenbus.Xb.Op.Reset_watches     -> "reset watches"
>        | Xenbus.Xb.Op.Set_target        -> "settarget"
> 
>        | Xenbus.Xb.Op.Error             -> "error    â

All still fine:

Acked-by: David Scott <dave.scott@xxxxxxxxxx>

Cheers,
Dave



> 
> 
>>> Acked-by: David Scott <dave.scott@xxxxxxxxxx>
>>> 
>>> Cheers,
>>> Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel