Re: [Xen-devel] [PATCH v2 5/5] libxl: spawns two QEMUs for HVM guests

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jun 04, 2015 at 12:28:19PM +0100, Stefano Stabellini wrote:
> Starts a second QEMU to provide PV backends in userspace to HVM guests.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl_create.c |   18 ++++++++++++++++++
>  tools/libxl/libxl_dm.c     |    9 ++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index a74b340..925738f 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -981,6 +981,15 @@ static void domcreate_console_available(libxl__egc *egc,
>                                          dcs->aop_console_how.for_event));
>  }
>  
> +static void qdisk_spawn_outcome(libxl__egc *egc, libxl__dm_spawn_state *dmss,
> +                                int rc)
> +{
> +    STATE_AO_GC(dmss->spawn.ao);
> +
> +    LOG(DEBUG, "qdisk backend spawn for domain %u %s", dmss->guest_domid,
> +               rc ? "failed" : "succeed");
> +}
> +

This fails to propagate rc. If qdisk backend spawn failed we should just
fail guest creation, right?

Also it looks very similar to the function with the same name in
libxl.c. I'm not sure why that doesn't propagate rc either...

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel