[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V6 06/10] tools/libxl: Set 'reg' of cpu node equal to MPIDR affinity for domU
On Mon, 2015-06-01 at 20:56 +0800, Chen Baozi wrote: > From: Chen Baozi <baozich@xxxxxxxxx> > > According to ARM CPUs bindings, the reg field should match the MPIDR's > affinity bits. We will use AFF0 and AFF1 when constructing the reg value > of the guest at the moment, for it is enough for the current max vcpu > number. > > Signed-off-by: Chen Baozi <baozich@xxxxxxxxx> > Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx> Actually, please ignore previous ack. [...] > + uint64_t mpidr_aff; [...] > + name = GCSPRINTF("cpu@%lx", mpidr_aff); The correct format specifier for a uint64_t is "%"PRIx64", otherwise you will break 32 bit build. With that changed you can put the ack back... Ian. > > res = fdt_begin_node(fdt, name); > if (res) return res; > @@ -297,7 +307,7 @@ static int make_cpus_node(libxl__gc *gc, void *fdt, int > nr_cpus, > res = fdt_property_string(fdt, "enable-method", "psci"); > if (res) return res; > > - res = fdt_property_regs(gc, fdt, 1, 0, 1, (uint64_t)i); > + res = fdt_property_regs(gc, fdt, 1, 0, 1, mpidr_aff); > if (res) return res; > > res = fdt_end_node(fdt); _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |