[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv11 2/4] gnttab: introduce maptrack lock



>>> On 02.06.15 at 18:26, <david.vrabel@xxxxxxxxxx> wrote:
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -288,10 +288,10 @@ static inline void put_maptrack_handle(
>      struct grant_table *t, int handle)
>  {
> -    spin_lock(&t->lock);
> +    spin_lock(&t->maptrack_lock);
>      maptrack_entry(t, handle).ref = t->maptrack_head;
>      t->maptrack_head = handle;
> -    spin_unlock(&t->lock);
> +    spin_unlock(&t->maptrack_lock);

Starting with this change it becomes unclear what protects the
maptrack entries - the grant table lock or the maptrack one?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.