[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC 04/22] xen/arm: gic-v3: Use the domain redistributor information to make the DT node
On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote: > It's not neccessary to get again from the hardware DT the redistributor "necessary" I'd say "It is not necessary to get the redistributor information from the hardware again". > informations. We already have it stored in the gic_info and the domain. > > Use the latter to be consistent with the rest of the function. Not just that, but consistent with what we are going to actually emulate, I think, since that may legitimately differ from the h/w. > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> > --- > xen/arch/arm/gic-v3.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 0b7f29b..16b1df4 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -1083,9 +1083,6 @@ static int gicv3_make_dt_node(const struct domain *d, > const void *compatible = NULL; > uint32_t len; > __be32 *new_cells, *tmp; > - uint32_t rd_stride = 0; > - uint32_t rd_count = 0; > - > int i, res = 0; > > compatible = dt_get_property(gic, "compatible", &len); > @@ -1111,19 +1108,13 @@ static int gicv3_make_dt_node(const struct domain *d, > if ( res ) > return res; > > - res = dt_property_read_u32(gic, "redistributor-stride", &rd_stride); > - if ( !res ) > - rd_stride = 0; > - > - res = dt_property_read_u32(gic, "#redistributor-regions", &rd_count); > - if ( !res ) > - rd_count = 1; > - > - res = fdt_property_cell(fdt, "redistributor-stride", rd_stride); > + res = fdt_property_cell(fdt, "redistributor-stride", > + d->arch.vgic.rdist_stride); > if ( res ) > return res; > > - res = fdt_property_cell(fdt, "#redistributor-regions", rd_count); > + res = fdt_property_cell(fdt, "#redistributor-regions", > + d->arch.vgic.nr_regions); > if ( res ) > return res; > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |