[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 for Xen 4.6 1/4] xen: enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
On Fri, 2015-05-29 at 11:47 -0500, Chong Li wrote: > On Fri, May 29, 2015 at 8:51 AM, Dario Faggioli > <dario.faggioli@xxxxxxxxxx> wrote: > > On Mon, 2015-05-25 at 19:05 -0500, Chong Li wrote: > > > >> diff --git a/xen/common/domctl.c b/xen/common/domctl.c > >> index 28aea55..8143c44 100644 > >> --- a/xen/common/domctl.c > >> +++ b/xen/common/domctl.c > > > > > /* Set or get info? */ > > #define XEN_DOMCTL_SCHEDOP_putinfo 0 > > #define XEN_DOMCTL_SCHEDOP_getinfo 1 > > #define XEN_DOMCTL_SCHEDOP_putvcpuinfo 2 > > #define XEN_DOMCTL_SCHEDOP_getvcpuinfo 3 > > struct xen_domctl_scheduler_op { > > uint32_t sched_id; /* XEN_SCHEDULER_* */ > > uint32_t cmd; /* XEN_DOMCTL_SCHEDOP_* */ > > union { > > xen_domctl_schedparam_t d; > > struct { > > XEN_GUEST_HANDLE_64(xen_domctl_schedparam_vcpu_t) vcpus; > > uint16_t nr_vcpus; > > } v; > > } u; > > }; > > typedef struct xen_domctl_scheduler_op xen_domctl_scheduler_op_t; > > DEFINE_XEN_GUEST_HANDLE(xen_domctl_scheduler_op_t); > > > > I'm also attaching a (build-tested only) patch to that effect (I'm > > killing SEDF in there, so I don't have to care about it, as it's going > > away anyway). > > > > Thoughts? > > > I see. So now we put per-dom params and per-vcpu params into the same > structure (xen_domctl_scheduler_op). This structure will be handled in > sched_adjust and there should be a "switch" in that function to > distinguish per-dom get/set and per-vcpu get/set. Right? > You're describing correctly what I had in mind and tried to do in the draft patch, yes. Whether to do it or not, well, it's a proposal. George says he also thinks the thing makes sense to him too, so I guess you can go ahead and try doing so in v3. Of course, others, feel free to chime in. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |