Re: [Xen-devel] [PATCH v1 4/5] tools/libxl: move toolstack code into libxl_toolstack.c

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-03 at 10:52 +0800, Yang Hongyang wrote:
> 
> On 06/03/2015 12:22 AM, Yang Hongyang wrote:
> >
> >
> > On 06/02/2015 10:48 PM, Ian Campbell wrote:
> >> On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote:
> >>> move toolstack code into libxl_toolstack.c
> >>
> >> It's not clear to me what "toolstack code" is here, the whole of libxl
> >> and xl is "toolstack code".
> >>
> >> Is the code being moved stuff to do with adding toolstack state to the
> >> save stream? Perhaps libxl_{suspend,save}_toolstack.c? Or could this not
> >> go in the libxl_dom_suspend.c you just created?
> >
> > My thought was libxl_dom_suspend.c only contains code that do vm suspend
> > stuff(not save). So compare to move it to dom_suspend.c, I prefer not
> > move it or use libxl_{suspend,save}_toolstack.c. Maybe leave the code
> > not moved?
> 
> I think I'm going to move this code into libxl_dom_save.c, by merge this
> patch with the next patch.

OK.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel