Re: [Xen-devel] [PATCH v3] dmar: device scope mem leak fix

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.06.15 at 09:00, <JBeulich@xxxxxxxx> wrote:
>>>> On 02.06.15 at 23:13, <elena.ufimtseva@xxxxxxxxxx> wrote:
>> --- a/xen/drivers/passthrough/vtd/dmar.c
>> +++ b/xen/drivers/passthrough/vtd/dmar.c
>> @@ -81,6 +81,12 @@ static int __init acpi_register_rmrr_unit(struct 
>> acpi_rmrr_unit *rmrr)
>>      return 0;
>>  }
>>  
>> +static void scope_devices_free(struct dmar_scope *scope)
>> +{
>> +    scope->devices_cnt = 0;
>> +    xfree(scope->devices);
>> +}
> 
> While it looks like this isn't an active problem, not storing NULL in
> scope->devices here looks like calling for future problems.

Or wait, perhaps not, as you're clearing devices_cnt.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel