[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1 3/5] tools/libxl: move remus codes into libxl_remus.c
On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote: > move remus codes into libxl_remus.c "code" Apart from dropping some "static" and adding some prototypes to the header this is purely motion, correct? (I assume this about the last one too). > diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h > index b2eeb89..c3d70eb 100644 > --- a/tools/libxl/libxl_internal.h > +++ b/tools/libxl/libxl_internal.h > @@ -2815,6 +2815,7 @@ _hidden void libxl__remus_devices_commit(libxl__egc > *egc, > libxl__remus_devices_state *rds); > _hidden int libxl__netbuffer_enabled(libxl__gc *gc); > > + Please avoid spurious whitespace changes. > /*----- Domain suspend (save) state structure -----*/ > > typedef struct libxl__domain_suspend_state libxl__domain_suspend_state; > @@ -3197,6 +3198,16 @@ void libxl__domain_suspend_callback(void *data); > void libxl__domain_suspend(libxl__egc *egc, > libxl__domain_suspend_state *dss); > > +/* Remus callbacks for save */ > +void libxl__remus_domain_suspend_callback(void *data); > +void libxl__remus_domain_resume_callback(void *data); > +void libxl__remus_domain_checkpoint_callback(void *data); > +/* Remus setup and teardown*/ > +void libxl__remus_setup(libxl__egc *egc, libxl__domain_save_state *dss); > +void libxl__remus_teardown(libxl__egc *egc, > + libxl__domain_save_state *dss, > + int rc); Please mark these all _hidden. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |