Re: [Xen-devel] [PATCH v2] xen: netback: fix printf format string warning

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jun 01, 2015 at 11:30:04AM +0100, Ian Campbell wrote:
> drivers/net/xen-netback/netback.c: In function âxenvif_tx_build_gopsâ:
> drivers/net/xen-netback/netback.c:1253:8: warning: format â%luâ expects 
> argument of type âlong unsigned intâ, but argument 5 has type âintâ 
> [-Wformat=]
>         (txreq.offset&~PAGE_MASK) + txreq.size);
>         ^
> 
> PAGE_MASK's type can vary by arch, so a cast is needed.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ----
> v2: Cast to unsigned long, since PAGE_MASK can vary by arch.
> ---
>  drivers/net/xen-netback/netback.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c 
> b/drivers/net/xen-netback/netback.c
> index 4de46aa..0d25943 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1250,7 +1250,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue 
> *queue,
>                       netdev_err(queue->vif->dev,
>                                  "txreq.offset: %x, size: %u, end: %lu\n",
>                                  txreq.offset, txreq.size,
> -                                (txreq.offset&~PAGE_MASK) + txreq.size);
> +                                (unsigned long)(txreq.offset&~PAGE_MASK) + 
> txreq.size);
>                       xenvif_fatal_tx_err(queue->vif);
>                       break;
>               }
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel