Re: [Xen-devel] [PATCH v3 2/2] efi: Avoid calling boot services after ExitBootServices()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.06.15 at 12:26, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/06/15 11:17, Ross Lagerwall wrote:
>> --- a/xen/common/efi/boot.c
>> +++ b/xen/common/efi/boot.c
>> @@ -216,6 +216,12 @@ static void __init noreturn blexit(const CHAR16 *str)
>>          PrintStr((CHAR16 *)str);
>>      PrintStr(newline);
>>  
>> +    if ( !efi_bs )
>> +    {
>> +        for ( ; ; )
>> +            ;
> 
> At the very least this should be halt() to avoid spinning in a busy
> loop, and probably with a local_irq_disable() ahead of the for.

Suitably abstracted, yes: ARM has no halt(), and I don't think we
should assume local_irq_disable() can be used here in a completely
arch-independent fashion. I.e. perhaps the whole body of the if()
should become a new arch hook.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel