Re: [Xen-devel] [PATCH v2 1/4] libxc/libxl: fill xc_hvm_build_args in libxl

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 29, 2015 at 01:29:18PM +0100, Andrew Cooper wrote:
> On 29/05/15 12:37, Wei Liu wrote:
> > When building HVM guests, originally some fields of xc_hvm_build_args
> > are filled in xc_hvm_build (and buried in the wrong function), some are
> > set in libxl__build_hvm before passing xc_hvm_build_args to
> > xc_hvm_build. This is fragile.
> >
> > After examining the code in xc_hvm_build that sets those fields, we can
> > in fact move setting of mmio_start etc in libxl. This way we consolidate
> > memory layout setting in libxl.
> >
> > The setting of firmware data related fields is left in xc_hvm_build
> > because it depends on parsing ELF image. Those fields only point to
> > scratch data that doesn't affect memory layout.
> >
> > There should be no change in the generated guest memory layout.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > ---
> > Cc: "Chen, Tiejun" <tiejun.chen@xxxxxxxxx>
> >
> > This might affect your RMRR patch series.
> 
> It should at least me noted that this is a semantic change in domain
> construction for all other toolstacks out there, an aid to the unlucky
> person forward porting something like Xapi and finding that a chunk of
> work is no longer performed by libxc.
> 

Right. I will write this in the commit message if I end up sending v3.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel