Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.05.15 at 12:39, <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, May 29, 2015 at 11:34:07AM +0100, Jan Beulich wrote:
>> >>> On 11.05.15 at 19:25, <venkat.x.venkatsubra@xxxxxxxxxx> wrote:
>> >>  
>> >> Please CC the maintainers of the driver. You can get that from
>> >> 'scripts/get_maintainer.pl'
>> >> 
>> >> I've done that for you.
>> > 
>> > Thanks, Konrad.
>> > 
>> > I am copying Wei too who had fixed the below problem earlier.
>> > It fixed the incorrect ip_hdr(). tcp_hdr() still needs to fixed.
>> > 
>> > commit d554f73df6bc35ac8f6a65e5560bf1d31dfebed9
>> > Author: Wei Liu <wei.liu2@xxxxxxxxxx>
>> > Date:   Wed Feb 19 18:48:34 2014 +0000
>> > 
>> >     xen-netfront: reset skb network header before checksum
>> 
>> So no response at all so far from the maintainers made me look into
>> this: I first thought what we need would be calls to
>> skb_probe_transport_header() in skb_checksum_setup_ip() after
>> each of the skb_maybe_pull_tail() functions. But
>> skb_partial_csum_set() already calls skb_set_transport_header(),
>> so I now think things ought to be fine without any change. Can
>> you clarify what you think is missing? Or is this an issue in just the
>> old (3.8.x) kernel you're using?
>> 
> 
> I think this is the follow-up thread <20150512013424.GA7960@xxxxxxxxxx>
> 
> And the conclusion is 3.8 is too old so the fix is not there.

Ah, right. Seems like I failed to remove the earlier mail from my list of
things to look at when this came through. Sorry for the noise then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel