Re: [Xen-devel] [PATCH net v2] xen/netback: Properly initialize credit_bytes

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, May 27, 2015 at 11:44:32AM +0100, Ross Lagerwall wrote:
> Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
> struct") introduced a regression when moving queue-specific data into
> the queue struct by failing to set the credit_bytes field. This
> prevented bandwidth limiting from working. Initialize the field as it
> was done before multiqueue support was added.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
> 
> Changed in v2: Fixed multiple-assignment.
> 
>  drivers/net/xen-netback/xenbus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/xen-netback/xenbus.c 
> b/drivers/net/xen-netback/xenbus.c
> index 3d8dbf5..fee0241 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -793,6 +793,7 @@ static void connect(struct backend_info *be)
>                       goto err;
>               }
>  
> +             queue->credit_bytes = credit_bytes;
>               queue->remaining_credit = credit_bytes;
>               queue->credit_usec = credit_usec;
>  
> -- 
> 2.1.0

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel