Re: [Xen-devel] [PATCH] libxl: Initialize valid_devs in output_topologyinfo()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 15, 2015 at 11:06:57AM -0400, Boris Ostrovsky wrote:
> Commit e78e8b9bb649 ("libxl: Add interface for querying hypervisor
> about PCI topology") neglected to initialize valid_devs. This
> may result in not printing a message to console if no IO topology
> information is available and, more importantly, may break non-debug
> builds on some versions of gcc.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Reported-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxl/xl_cmdimpl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 373aa37..6d60ce4 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -5423,7 +5423,7 @@ static void output_topologyinfo(void)
>      libxl_cputopology *cpuinfo;
>      int i, nr;
>      libxl_pcitopology *pciinfo;
> -    int valid_devs;
> +    int valid_devs = 0;
>  
>  
>      cpuinfo = libxl_get_cpu_topology(ctx, &nr);
> -- 
> 1.7.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel