Re: [Xen-devel] [PATCH v2 02/41] arm/acpi: Build pmstat for x86 only

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.05.15 at 22:03, <parth.dixit@xxxxxxxxxx> wrote:
> Pmstat is currently not supported for arm in xen.
> Configure and build pmstat for x86 architecture only.

Same here as for patch 1. If the architecture can be expected to
eventually support a feature, I'd generally prefer the architecture
to get necessary stubs added over fiddling with common code.

> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) 
> u_sysctl)
>          op->u.availheap.avail_bytes <<= PAGE_SHIFT;
>          break;
>  
> +#ifdef CONFIG_X86
>  #ifdef HAS_ACPI
>      case XEN_SYSCTL_get_pmstat:
>          ret = do_get_pm_info(&op->u.get_pmstat);

Please fold the two #if-s into one, or even replace the HAS_ACPI
one if this really needs to be done.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel