Re: [Xen-devel] [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 05/20/15 09:10, Andrew Cooper wrote:
> This structure is used by XEN_DOMCTL_createdomain, and is liable to be
> modified going forwards.  Explicitly state that it falls under the
> XEN_DOMCTL_INTERFACE_VERSION.
> 

Looks good to me.

Reviewed-by: Don Slutz <dslutz@xxxxxxxxxxx>

   -Don Slutz

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxxxxx>
> CC: Don Slutz <dslutz@xxxxxxxxxxx>
> ---
>  xen/include/public/arch-arm.h     |    4 ++++
>  xen/include/public/arch-x86/xen.h |    4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index c029e0f..6e38638 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -309,6 +309,10 @@ struct arch_shared_info {
>  typedef struct arch_shared_info arch_shared_info_t;
>  typedef uint64_t xen_callback_t;
>  
> +/*
> + * struct xen_arch_domainconfig's ABI is covered by the
> + * XEN_DOMCTL_INTERFACE_VERSION.
> + */
>  #define XEN_DOMCTL_CONFIG_GIC_DEFAULT   0
>  #define XEN_DOMCTL_CONFIG_GIC_V2        1
>  #define XEN_DOMCTL_CONFIG_GIC_V3        2
> diff --git a/xen/include/public/arch-x86/xen.h 
> b/xen/include/public/arch-x86/xen.h
> index cea3fe7..b4ba233 100644
> --- a/xen/include/public/arch-x86/xen.h
> +++ b/xen/include/public/arch-x86/xen.h
> @@ -262,6 +262,10 @@ struct arch_shared_info {
>  };
>  typedef struct arch_shared_info arch_shared_info_t;
>  
> +/*
> + * struct xen_arch_domainconfig's ABI is covered by the
> + * XEN_DOMCTL_INTERFACE_VERSION.
> + */
>  struct xen_arch_domainconfig {
>      char dummy;
>  };
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel