Re: [Xen-devel] [OSSTEST PATCH 5/6] ts-xen-build-prep: mkfs a new /home/osstest, don't resize2fs

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-05-14 at 18:48 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 5/6] ts-xen-build-prep: mkfs a new 
> /home/osstest, don't resize2fs"):
> > On Wed, 2015-05-13 at 12:15 +0100, Ian Jackson wrote:
> > > + echo '$mapper $dir $fstype defaults 0 0' >>/etc/fstab
> > 
> > This doesn't update /etc/fstab so in standalone mode (when a host may
> > share build and test duties) the reboots will cause the
> > old /home/osstest to reappear and then I'm not sure if this all does
> > what we want or not with the existing lv.
> 
> That line there is the update to /etc/fstab.

Sorry, I triple checked for it and I've no idea how I missed it every
time.

> The result is that if the host reboots the new fs should be mounted,
> and then when this runs again this
> 
> > > + if mount | sed -e 's/^[^ ].* on //; s/ .*//' | grep -F '$dir'; then
> > > +     exit 0
> > > + fi
> 
> is supposed to arrange that the whole thing is a no-op.
> 
> Also note that the script makes the mount point with mode 2700 so that
> normal build scripts will crash if the fs is not mounted for some
> reason:
> 
> > +   mkdir -m 2700 $dir

Right, all sounds exactly how I thought it should work:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

There is an osstest in progress, the first bite of the cherry failed
with one of the intermittent failures. So IMHO you may as well append to
pretest when ever you are ready, if the current attempt happens to fail
again then there's no harm adding this lot into the mix for next time.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel