Re: [Xen-devel] [RFC][PATCH 12/13] hvmloader/pci: skip reserved ranges

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.05.15 at 09:34, <tiejun.chen@xxxxxxxxx> wrote:
> So I think we may need to adjust pci_mem_start like this,
> 
> @@ -301,6 +301,19 @@ void pci_setup(void)
>               pci_mem_start <<= 1;
>       }
> 
> +    /* Relocate PCI memory that overlaps reserved space, like RDM. */
> +    for ( j = 0; j < memory_map.nr_map ; j++ )
> +    {
> +        if ( memory_map.map[j].type != E820_RAM )
> +        {
> +            reserved_end = memory_map.map[j].addr + memory_map.map[j].size;
> +            if ( check_overlap(pci_mem_start, pci_mem_end,
> +                               memory_map.map[j].addr,
> +                               memory_map.map[j].size) )
> +                pci_mem_start -= memory_map.map[j].size >> PAGE_SHIFT;
> +        }
> +    }
> +
>       if ( mmio_total > (pci_mem_end - pci_mem_start) )
>       {
>           printf("Low MMIO hole not large enough for all devices,"
> 
> Right?

I think that gets you in the right direction, but isn't enough, as it
doesn't account for (unavoidable) gaps (BARs are always a power
of 2 in size and accordingly aligned).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel