Re: [Xen-devel] [PATCH v6 06/16] tools/libxc: add a check in xc_hypercall_buffer_free_pages macro

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-05-14 at 16:55 +0800, Yang Hongyang wrote:
> When we use a DECLARE_HYPERCALL_BUFFER_SHADOW define a user
                                                ^it defines

> pointer '_name' and a shadow xc_hypercall_buffer_t.
> then call xc_hypercall_buffer_free_pages(_xch, _name, _nr),
  ^When then calling

> the complier will report '_name' unused error, it's because
                                                 ^drop it's

> xc_hypercall_buffer_free_pages() is a MACRO and '_name'
                                                         ^is

> transparently converted to the hypercall buffer. it confused
                                                      confuses

> the caller because xc_hypercall_buffer_free_pages() do look
                                                      looks

> like a function and take '_name' as an arg.
                       takes

> Add an if check to let the compiler think we are actually
> using the argument '_name'.
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>

I can fix those on commit if there is no other reason for a v7. 

Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel