Re: [Xen-devel] [RFC PATCH v2 09/22] xen/arm: its: Add helper functions to decode ITS Command

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 11/05/15 15:25, Julien Grall wrote:
> Hi Vijay,
> 
> On 11/05/15 15:14, Vijay Kilari wrote:
>> On Wed, Apr 1, 2015 at 5:10 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
>>> On Thu, 2015-03-19 at 20:07 +0530, vijay.kilari@xxxxxxxxx wrote:
>>>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>>>
>>>> Add helper functions to decode ITS command
>>>> This will be useful for Virtual ITS driver
>>>
>>> It depends slightly on the answer to the quesiton I asked on patch #6,
>>> but in general in Xen we have preferred to define a structure/union
>>> overlaying the processor's view of such things and to use access to
>>> those fields, see e.g. the hsr decode or the pte stuff.
>>
>>    This make heavy and simple changes. I prefer to make it a separate
>> patch series.
> 
> We are at early stage of the review process, it's the second version and
> the design is not yet set in stone. So it's normal to have heavy changes
> in the code between 2 versions.
> 
> Although, when you say heavy, it's compare to what? The GICv3 ITS driver?

* from Linux?


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel