Re: [Xen-devel] [PATCH v3 1/5] xen: dt: add dt_for_each_irq_map helper

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 08/05/15 11:27, Ian Campbell wrote:
>>> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
>>> index 57eb3ee..91bd23a 100644
>>> --- a/xen/include/xen/device_tree.h
>>> +++ b/xen/include/xen/device_tree.h
>>> @@ -528,6 +528,18 @@ int dt_device_get_raw_irq(const struct dt_device_node 
>>> *device,
>>>  int dt_irq_translate(const struct dt_raw_irq *raw, struct dt_irq *out_irq);
>>>  
>>>  /**
>>> + * dt_for_each_irq_map - Iterate over a nodes interrupt-map property
>>> + * @dev: The node whose interrupt-map property should be iterated over
>>> + * @cb: Call back to call for each entry
>>> + * @data: Caller data passed to callback
>>> + */
>>> +int dt_for_each_irq_map(const struct dt_device_node *dev,
>>> +                        int (*cb)(const struct dt_device_node *,
>>> +                                  const struct dt_raw_irq *,
>>> +                                  void *),
>>
>> I would add a typedef for the callback.
> 
> It's only used in this one place, so I don't think it's really needed
> and the obvious name dt_for_each_irq_map_cb is super clumsy.
> 
> Also you didn't say the same thing to the cb in the next patch ;-).

I don't mind you if you don't add a typedef. It was only for avoid
duplicating the type everytime.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel