Re: [Xen-devel] [PATCH 1/5] xen/vm_event: Added support for XSETBV events

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 07/05/15 16:43, Tim Deegan wrote:
> At 20:12 +0300 on 06 May (1430943148), Razvan Cojocaru wrote:
>> This patch adds XSETBV (XCR) vm_events.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> After making things more architecture-neutral in the API rework, it
> seems a shame to have this called 'xsetbv'.  But since we already have
> CR0 etc in this interface, I guess that's OK.  
>
> Acked-by: Tim Deegan <tim@xxxxxxx>

While we are still in the period of ABI flux, might it be appropriate to
take the cleanup one step further and separate the common ABI/API from
architecture specific bits?

e.g. split public/vm_event.h to have arch-x86/vm_event.h as well, and
declare VM_EVENT_REASON_ARCH starting at 0x80000000 or so?  The x86
specific structures can become vm_event_x86_$foo.

It seems worthwhile, and we have until 4.6 is released to make changes
like this.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel