Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, May 7, 2015 at 11:35 AM, Olaf Hering <olaf@xxxxxxxxx> wrote:
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

[snip]

> +        case TRC_SCHED_ADJDOM:
> +            printf(" %s sched_adjdom domid d%u\n",
> +                   ri->dump_header, ri->d[0]);
> +            break;

<aside>Wow, this has got to be one of the most useless trace points
ever...</aside>

>          case TRC_SCHED_SWITCH:
>              sched_switch_process(p);
>              break;
> +        case TRC_SCHED_SWITCH_INFPREV:
> +            printf(" %s switch_infprev old_domid %x runtime %d\n",
> +                   ri->dump_header, ri->d[0], ri->d[1]);
> +            break;
> +        case TRC_SCHED_SWITCH_INFNEXT:
> +            printf(" %s switch_infnext new_domid %x time %d r_time %d\n",
> +                   ri->dump_header, ri->d[0], ri->d[1], ri->d[2]);
> +            break;
>          default:
> -            process_generic(&p->ri);
> -        }
> -    } else {
> -        if(ri->evt.sub == 1)
> -            sched_runstate_process(p);
> -        else {
> +            fprintf(warn, "%s: event:%x (min:%x sub:%x main:%x)\n", 
> __func__, ri->event, ri->evt.minor, ri->evt.sub, ri->evt.main);

Make this warning something like "Unknown event" instead?

Other than that, looks good, thanks.  Been meaning to do this for a
long time. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel