Re: [Xen-devel] [PATCH v2] OSSTEST: introduce a raisin build test

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 6 May 2015, Ian Campbell wrote:
> On Wed, 2015-05-06 at 15:43 +0100, Stefano Stabellini wrote:
> [...]
> > +    echo >>config ENABLED_COMPONENTS=\\"seabios ovmf xen qemu 
> > qemu_traditional libvirt\\"
> [...]
> > +    echo >>config XEN_URL=\\"$r{tree_xen}\\"
> > +    echo >>config QEMU_URL=\\"$r{tree_qemuu}\\"
> > +    echo >>config QEMU_TRADITIONAL_URL=\\"$r{tree_qemu}\\"
> > +    echo >>config SEABIOS_URL=\\"$r{tree_seabios}\\"
> > +    echo >>config LIBVIRT_URL=\\"$r{tree_libvirt}\\"
> > +    echo >>config OVMF_URL=\\"$r{tree_ovmf}\\"
> 
> What will raisin do if one or more of these runvars is not set for some
> reason yet the thing is listed in ENABLED_COMPONENTS?

It will fail with an error and quit


> > +    store_revision($ho, 'xen', "$raisindir/xen-dir", 1);
> > +    store_revision($ho, 'qemu', "$raisindir/qemu-traditional-dir", 1);
> > +    store_revision($ho, 'qemuu', "$raisindir/qemu-dir", 1);
> > +    store_revision($ho, 'seabios', "$raisindir/seabios-dir", 1);
> > +    store_revision($ho, 'ovmf', "$raisindir/ovmf-dir", 1);
> > +    store_revision($ho, 'libvirt', "$raisindir/libvirt-dir", 1);
> 
> Is $component-dir considered a stable path in raisin (i.e. will you
> promise not to change it).

This is a good point. If it is not stable now, it will have to be stable
by the time this patch is accepted :-)


> > +}
> > +
> > +sub divide () {
> > +    # Only move hv to xeninstall, so that we can have
> > +    # xenpolicy in tools tarball.
> > +    #
> > +    # The files inside boot/ after `make dist' are
> > +    # xen-$XEN_VERSION: Xen binary
> > +    # xen.gz/xen: symlink to xen-$XEN_VERSION
> > +    # xen-$MAJOR: symlink to xen-$XEN_VERSION
> > +    # xen-$MAJOR.$MINOR: symlink to xen-$XEN_VERSION
> > +    # xen-sym-$XEN_VERSION: Xen symbol
> > +    # xenpolicy-$XEN_VERSION: flask policy binary if xsm is enabled
> > +    #
> > +    # So the following snippet will leave xenpolicy* in
> > +    # install/boot and get packaged to tools tarball.
> > +    target_cmd_build($ho, 100, $builddir, <<END);
> > +        cd raisin
> 
> $raisindir? (here and in various places further down)

OK

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel