Re: [Xen-devel] [PATCH 5/7] xenalyze: disable sched_switch_process

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Apr 28, 2015 at 07:58:44AM +0200, Olaf Hering wrote:
> On Tue, Apr 28, Wei Liu wrote:
> 
> > On Mon, Apr 27, 2015 at 01:22:14PM +0000, Olaf Hering wrote:
> > > It causes a crash, dump data and return early
> 
> > This doesn't look right. You skip all things below.
> 
> Yes, to avoid the crash when booted with "tbuf_size=-1". When I noticed
> that I did not have the energy to dig into how the vcpu machinery works.
> Appearently it cant cope with bootup data.
> 

Ergh... George might have an idea of the bug you met.

I'm not in favour of short-circuiting code like this. If this is really
necessary please either delete dead code or use #ifdef 0 with proper
comment.

Wei.

> Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel