Re: [Xen-devel] [PATCH 2/3] x86/hvm: introduce functions for HVMOP_get/set_param allowance checks

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Paul Durrant <paul.durrant@xxxxxxxxxx> 04/24/15 6:35 PM >>>
>+    /* The following parameters cannot be set by the guest */

Please add a stop ad the end of at least sentence-like comments.

>case HVM_PARAM_DM_DOMAIN:
>-        /* Not reflexive, as we may need to domain_pause(). */

Especially when the reason for not allowing guest access is other than a
simple permission thing, I think for documentation purposes it would be
useful to retain these comments.

a.value = current->domain->domain_id;
 
         >+    /* The following parameters cannot be read by the guest */

Perhaps "cannot" isn't the right term here - "shouldn't"?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel