Re: [Xen-devel] [PATCH v5 p2 15/19] tools/(lib)xl: Add partial device tree support for ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 09/04/15 17:13, Ian Jackson wrote:
> Julien Grall writes ("[PATCH v5 p2 15/19] tools/(lib)xl: Add partial device 
> tree support for ARM"):
>> Let the user to pass additional nodes to the guest device tree. For
>> this purpose, everything in the node /passthrough from the partial
>> device tree will be copied into the guest device tree.
> 
> Thanks for explaining to me in person what I was missing about the
> semantics of DTs.  As I said, you may wish to explain some of this in
> the commit message or some of the in-tree documents, perhaps with
> references.  I will leave that up to you.

I will add a link to [1] in the in-tree documentation (patch #19).

[1] http://www.devicetree.org/Device_Tree_Usage#Basic_Data_Format

> In any case,
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Although:
> 
>> +    # Given the complexity of verifying the validity of a device tree,
>> +    # libxl doesn't do any security check on it. It's the responsability
> 
> Spelling mistake - should be "responsibility".

I will fix it.

Thanks,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel