Re: [Xen-devel] libxl, flexarray_append_pair usage

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Apr 24, 2015 at 11:16:00AM +0200, Olaf Hering wrote:
> On Fri, Apr 24, Olaf Hering wrote:
> 
> >      flexarray_append(back, "state");
> > -    flexarray_append(back, GCSPRINTF("%d", 1));
> > +    flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising));
> 
> Should all such code be converted to flexarray_append_pair?
> To reduce line length a short macro should be added, like FLXAP or
> FLXPAIR or something else.

I don't have very strong opinion on this.

Wei.

> 
> Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel